WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@c-spiess
Copy link

  • moved 2016 version matrix.c to new 20160418 directory
  • renamed keyboard.json to info.json and removed indicators
  • copied 20160418/matrix.c to 20130602/matrix.c and modified col/row matrix pin config
  • created 2013/2016 keyboard.json with different pin config for indicators

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* moved 2016 version matrix.c to new 20160418 directory
* renamed keyboard.json to info.json and removed indicators
* copied 20160418/matrix.c to 20130602/matrix.c and modified col/row matrix pin config
* created 2013/2016 keyboard.json with different pin config for indicators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PR checklist

when configuring custom matrix, the 'lite' variant (CUSTOM_MATRIX = lite) must be used where possible, as this allows for standard debounce. See custom matrix 'lite'

This file in its current form will no longer be accepted, and will need to be updated to use lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants