-
-
Notifications
You must be signed in to change notification settings - Fork 43.1k
Allow larger autocorrect dictionaries via configurable link size #25838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MustafaNisar2002
wants to merge
5
commits into
qmk:develop
Choose a base branch
from
MustafaNisar2002:feature/autocorrect-large-dicts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow larger autocorrect dictionaries via configurable link size #25838
MustafaNisar2002
wants to merge
5
commits into
qmk:develop
from
MustafaNisar2002:feature/autocorrect-large-dicts
+80
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified autocorrect functionality and improved documentation.
4 tasks
drashna
reviewed
Nov 29, 2025
drashna
approved these changes
Dec 7, 2025
zvecr
requested changes
Dec 7, 2025
| # error "AUTOCORRECT_LINK_BYTE_COUNT must be either 2 or 3 bytes." | ||
| #endif | ||
|
|
||
| #if defined(__AVR__) && DICTIONARY_SIZE > UINT16_MAX |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would not accept platform specific logic in core, when there is an abstraction in place that already exists.
platforms/progmem.h would need to be updated to add pgm_read_byte_far compatibility.
Suggested change
| #if defined(__AVR__) && DICTIONARY_SIZE > UINT16_MAX | |
| #if DICTIONARY_SIZE > UINT16_MAX |
Member
|
You also have both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relaxes the size limit on autocorrect dictionaries so tables larger than 64KB can be generated and used safely.
AUTOCORRECT_LINK_BYTE_COUNTdefined in the generated header.AUTOCORRECT_LINK_BYTE_COUNTin generatedautocorrect_data.hfiles and annotate the default autocorrect dictionary with its link size.docs/features/autocorrect.md.Types of Changes
Issues Fixed or Closed by This PR
Checklist
python -m compileall lib/python/qmk/cli/generate/autocorrect_data.pyand firmware builds with a generated dictionary).