Fix incorrect NEEDED entry due to unneeded shared lib reference #683
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-07
force-pushed
the
UnnecessaryDTNeeded
branch
from
0044f52 to
27ca78c
Compare
|
|
||
| InputSym->setResolveInfo(*(ResolvedResult.Info)); | ||
|
|
||
| if (ResolvedResult.Overriden || !ResolvedResult.Existent) { |
Contributor
There was a problem hiding this comment.
Should the condition be changed here ?
Contributor
Author
There was a problem hiding this comment.
No, this does not need to be changed.
This commit fixes the incorrect NEEDED entry when --as-needed is used and a shared library symbol is referenced by an another unneeded shared library. The root cause of the issue was the logic that was used to determine whether a shared library symbol ResolveInfo should have an outSymbol or not. Resolves qualcomm#668 Signed-off-by: Parth Arora <[email protected]>
partaror
force-pushed
the
UnnecessaryDTNeeded
branch
from
27ca78c to
881932d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the incorrect NEEDED entry when --as-needed is used and a shared library symbol is referenced by an another unneeded shared library.
The root cause of the issue was the logic that was used to determine whether a shared library symbol ResolveInfo should have an outSymbol or not.
Resolves #668