WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@yusufkandemir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Code style update
  • Refactor

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

Other information:
Fixes #17858

@github-actions
Copy link

Build Results

JSON API

📜 No changes detected.

Types

📜 Changes detected:

diff --git a/./current-build/types/utils/date.d.ts b/./pr-build/types/utils/date.d.ts
index 542cf47..599e796 100644
--- a/./current-build/types/utils/date.d.ts
+++ b/./pr-build/types/utils/date.d.ts
@@ -38,72 +38,83 @@ export type DateUnitOptions =
   | "year"
   | "years";
 
+export type DateInput = Date | number | string;
+
 export namespace date {
   function isValid(date: number | string): boolean;
+
   function extractDate(str: string, mask: string, locale?: DateLocale): Date;
+
   function buildDate(options: DateOptions, utc?: boolean): Date;
+
   function getDayOfWeek(date: Date): number;
-  function getWeekOfYear(date: Date | number | string): number;
+
+  function getWeekOfYear(date: DateInput): number;
+
   function isBetweenDates(
-    date: Date | number | string,
-    from: Date | number | string,
-    to: Date | number | string,
+    date: DateInput,
+    from: DateInput,
+    to: DateInput,
     opts?: { inclusiveFrom: boolean; inclusiveTo: boolean; onlyDate: boolean },
   ): boolean;
-  function addToDate(date: Date | number | string, options: DateOptions): Date;
-  function subtractFromDate(
-    date: Date | number | string,
-    options: DateOptions,
-  ): Date;
+
+  function addToDate(date: DateInput, options: DateOptions): Date;
+
+  function subtractFromDate(date: DateInput, options: DateOptions): Date;
+
   function adjustDate(
-    date: Date | number | string,
+    date: DateInput,
     options: DateOptions,
     utc?: boolean,
   ): Date;
+
   function startOfDate(
-    date: Date | number | string,
+    date: DateInput,
     option: DateUnitOptions,
     utc?: boolean,
   ): Date;
+
   function endOfDate(
-    date: Date | number | string,
+    date: DateInput,
     option: DateUnitOptions,
     utc?: boolean,
   ): Date;
-  function getMaxDate(
-    date: Date | number | string,
-    ...args: (Date | number | string)[]
-  ): Date;
-  function getMinDate(
-    date: Date | number | string,
-    ...args: (Date | number | string)[]
-  ): Date;
+
+  function getMaxDate(...args: DateInput[]): Date;
+
+  function getMinDate(...args: DateInput[]): Date;
+
   function getDateDiff(
-    date: Date | number | string,
-    subtract: Date | number | string,
+    date: DateInput,
+    subtract: DateInput,
     unit?: `${DateUnitOptions}s`,
   ): number;
-  function getDayOfYear(date: Date | number | string): number;
-  function inferDateFormat(
-    date: Date | number | string,
-  ): "date" | "number" | "string";
+
+  function getDayOfYear(date: DateInput): number;
+
+  function inferDateFormat(date: DateInput): "date" | "number" | "string";
+
   function getDateBetween(
-    date: Date | number | string,
-    min?: Date | number | string,
-    max?: Date | number | string,
+    date: DateInput,
+    min?: DateInput,
+    max?: DateInput,
   ): Date;
+
   function isSameDate(
-    date: Date | number | string,
-    date2: Date | number | string,
+    date: DateInput,
+    date2: DateInput,
     unit?: DateUnitOptions,
   ): boolean;
-  function daysInMonth(date: Date | number | string): number;
+
+  function daysInMonth(date: DateInput): number;
+
   function formatDate(
-    date: Date | number | string | undefined,
+    date: DateInput | undefined,
     format?: string,
     locale?: DateLocale,
     __forcedYear?: number,
     __forcedTimezoneOffset?: number,
   ): string;
-  function clone<D extends Date | number | string>(date: D): D;
+
+  function clone<D extends DateInput>(date: D): D;
 }

@yusufkandemir yusufkandemir changed the title fix(ui): loosen getMinData/getMaxData types to allow spread usage (fix: #17858) fix(ui): loosen getMinDate/getMaxDate types to allow spread usage (fix: #17858) Jun 18, 2025
@yusufkandemir yusufkandemir merged commit 809244a into quasarframework:dev Jun 18, 2025
1 check passed
@yusufkandemir yusufkandemir deleted the fix-17858-ui-loosen-date-util-types branch June 18, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loosen getMinDate/getMaxDate date utils types for spread usage

1 participant