WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Fix device_memory_resource_view. #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 2 commits into from
Nov 26, 2025
Merged

Fix device_memory_resource_view. #2166

rapids-bot merged 2 commits into from
Nov 26, 2025

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Nov 26, 2025

Description

CI is failing in libcudf. I missed committing some local changes that were meant to go into #2162.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 26, 2025 21:43
@bdice bdice requested review from shrshi and vyasr November 26, 2025 21:43
bdice
bdice commented Nov 26, 2025
View reviewed changes
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Nov 26, 2025
@bdice bdice self-assigned this Nov 26, 2025
@bdice bdice moved this to In Progress in RMM Project Board Nov 26, 2025
@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2025

/merge

@rapids-bot rapids-bot bot merged commit fcddf31 into rapidsai:main Nov 26, 2025
81 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in RMM Project Board Nov 26, 2025
@pxLi pxLi mentioned this pull request Nov 27, 2025
Closed
bdice added a commit to bdice/rmm that referenced this pull request Nov 27, 2025
@bdice
Revert "Fix device_memory_resource_view. (rapidsai#2166)"
49d59f6 
This reverts commit fcddf31.
@bdice bdice mentioned this pull request Nov 27, 2025
Merged
rapids-bot bot pushed a commit that referenced this pull request Nov 27, 2025
@bdice
Revert 2162 and 2166 (#2167)
cbc9ddc 
- Revert "Fix device_memory_resource_view. (#2166)"
- Revert "Compatibility updates for CCCL 3.2 (#2162)"

This unblocks some build failures observed in RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)

URL: #2167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees

@bdice bdice

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

RMM Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdice @ttnghia @davidwendt