Issue 41 empty interface requests responses #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me and GetNotes methods - Added OrderCreateResponse struct with fields for order creation response. - Implemented GetNotes method to retrieve notes as a map of strings. - Implemented CreatedTime method to convert CreatedAt to time.Time. - Added OrderCreateRequest struct with fields for order creation request.
…ted with interface{} type because i need to give struct here it can then convert it to jsonbytes after, i will be better this way
…eResponse structs
- Updated Order.Create method to accept OrderCreateRequest struct instead of map[string]interface{}.
- Modified Order.Create method to return OrderCreateResponse struct instead of map[string]interface{}.
- Added JSON marshaling and unmarshaling to convert between structs and JSON data.
- Improved type safety and readability by using defined structs for request and response data.
Refactor TestOrderCreate to use resources.OrderCreateRequest instead of map[string]interface{}
- Updated TestOrderCreate to use resources.OrderCreateRequest struct for request parameters.
- Replaced map[string]interface{} with resources.OrderCreateRequest in the test.
- Ensured the test setup and assertions remain consistent with the new struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.
TestOrderCreate for test
https://github.com/razorpay/razorpay-go/blob/master/resources/order_test.go
i have try to use
structinstead ofmap[string]interface{}fororder.Create.