feat: added order api request and response structs #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types/order_types.go
Outdated
Comment on lines
3
to
6
| type OrderRequest struct { | ||
| Amount int `json:"amount"` | ||
| Currency string `json:"currency"` | ||
| Receipt string `json:"receipt"` |
Contributor
There was a problem hiding this comment.
let's add all the request/resp params specified in docs as well?
https://razorpay.com/docs/api/orders/create
so, let's add first_payment_min_amount and partial_payment as well here.
types/order_types.go
Outdated
Comment on lines
1
to
2
| package types | ||
|
|
Contributor
There was a problem hiding this comment.
Let's add these definitions in the resources/order.go file itself but probably at the top of the file.
requests/request.go
Outdated
Comment on lines
279
to
280
| // Call makes an HTTP request to the Razorpay API | ||
| func (request *Request) Call(method, path string, params interface{}, result interface{}) error { |
Contributor
There was a problem hiding this comment.
let's have separate fields for params and payload. POST can have both params and payload
Contributor
There was a problem hiding this comment.
Call(method, path string, payload any, params interface{}, result interface{})
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add api request and response structs
OrderRequestandOrderResponsestruct forcreate order&fetching order by id