issue-fixing #475
Open
issue-fixing #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntax error, unexpected ')'
lbajsarowicz
suggested changes
Mar 12, 2025
lbajsarowicz
left a comment
lbajsarowicz
left a comment
There was a problem hiding this comment.
🟡 There's a better way to handle logs.
| $response->setHttpResponseCode(400); | ||
|
|
||
| $this->logger->critical("Razorpay Order: Payment already made for order :" . $receipt_id,); | ||
| $this->logger->critical("Razorpay Order: Payment already made for order :" . $receipt_id); |
There was a problem hiding this comment.
Please acknowledge the PSR-3 standard for LoggerInterface: https://www.php-fig.org/psr/psr-3/
You'll be able to find there's a 2nd argument in each logger method -- $context, you can pass an array of contextual information for an event.
Suggested change
| $this->logger->critical("Razorpay Order: Payment already made for order :" . $receipt_id); | |
| $this->logger->critical("Razorpay Order: Payment already made", ['order_id' => $receipt_id]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax error, unexpected ')'
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.