WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Fix for RangeCalendar onClear not working #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sierracrum-riskalyze wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for RangeCalendar onClear not working #653

sierracrum-riskalyze wants to merge 2 commits into from

Conversation

@sierracrum-riskalyze
Copy link

@sierracrum-riskalyze sierracrum-riskalyze commented Feb 7, 2020

This PR fixes two things:

  • It fixes a failling snapshot.
  • Adds missing props to RangeCalendar.tsx and CalendarPart.tsx which were causing the following error when attempting to clear the values on the range calendar:

Screen Shot 2020-02-07 at 10 43 36 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenshuai2144 chenshuai2144 Awaiting requested review from chenshuai2144

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sierracrum-riskalyze