Fix invalid JSX being generated for empty fragments #8077
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Dec 9, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
nojaf
approved these changes
Dec 9, 2025
cristianoc
approved these changes
Dec 9, 2025
| assuming "JsxRuntime". *) | ||
| let is_fragment = | ||
| match tag.expression_desc with | ||
| | J.Var (J.Qualified ({id = {name = "JsxRuntime"}}, Some "Fragment")) -> |
Collaborator
There was a problem hiding this comment.
pre-existing, but this is terrible
is there at least a file where all the "interesting" jsx preserve mode things like this are collected?
So one at least knows where to look?
Member
Author
There was a problem hiding this comment.
I don't know of such a file or if there are more similar problems.
I can create an issue for tracking this though.
cknitt
force-pushed
the
fix-empty-fragments
branch
from
0af7536 to
5a55f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8076