reanalyze: make optional args analysis liveness-aware #8082
+204
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
added a commit
that referenced
this pull request
Dec 9, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
|
Please rebase and move the CHANGELOG entry to 12.0.2. |
Optional argument analysis now only considers calls from live code when determining which optional arguments are unused. This prevents false positives when a function is only called from dead code. Changes: - Add pos_from to optional_arg_call to track caller binding position - Add is_live predicate to compute_optional_args_state - Two-pass solve: first compute deadness, then optional args with liveness - Add Decl.isLive helper to simplify repeated liveness checks - Update ARCHITECTURE.md to document the two-pass approach Signed-Off-By: Cristiano Calcagno <[email protected]>
cristianoc
force-pushed
the
reanalyze-liveness-aware-optional-args
branch
from
b71cd1b to
4637d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional argument analysis now only considers calls from live code when determining which optional arguments are unused. This prevents false positives when a function is only called from dead code.
Changes: