WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@rabrowne85
Copy link

@rabrowne85 rabrowne85 commented Jul 17, 2025

✨ Pull Request

📓 Referenced Issue

There is no specific issue that directly prompted this PR, but it includes a fix for:

ℹ️ About the PR

This PR updates all project dependencies to their latest compatible versions, as resolved by the package manager.

Key changes include:

  • ElectronJS has been upgraded to a more recent release, which includes a newer Chromium version. This enables support for modern web APIs and features.
  • TailwindCSS has been upgraded to v4.

While no breaking changes have been identified so far, due to the broad scope of dependency updates, this might be best classified as a minor version bump. Please advise if a major version is more appropriate.

Note: The project does not appear to have a comprehensive test suite, though npm run test completes successfully. 🤷‍♂️

🖼️ Testing Scenarios / Screenshots

The following commands were run to validate the changes:

  • npm run start
  • npm run build
  • npm run package
  • npm run test

While the test script completes, it's unclear how much coverage it provides.

Screenshots to follow

Items Outstanding

  • Preload script cannot be loaded into the webviews - therefore browserSync does not work.
  • React Dev Tools does not load.

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2025

CLA assistant check
All committers have signed the CLA.

@radiorambo
Copy link

Any update on this? @rabrowne85 @manojVivek

@rabrowne85
Copy link
Author

Any update on this? @rabrowne85 @manojVivek

No real update - there is one outstanding issue that I've had on the back burner which is keeping the views in sync with each other. For some reason the browser sync package is no longer keeping things together and there's no obvious reason why not. I'll try and get a couple of hours on it this morning 👍

@rabrowne85
Copy link
Author

@manojVivek I've managed to get the preload to work and as such the browserSync also works.

I see that the test workflow fails as it's using node 16 - any objections bumping this to at least 18?

I've merged the current master branch in so that any recent updates are included.

Think the main "breaking changes" are going to be from the electron update, i.e., macOS 11 or older are no longer supported. Do you want to go to v2.x or v1.18.x?

@rabrowne85
Copy link
Author

@manojVivek Any thoughts on the questions of whether to go v2 and/or adjust the config of the GitHub action? Would be good to get this in for review and merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the browsers

3 participants