-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Chore/upgrade dependencies #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chore/upgrade dependencies #1390
Conversation
…lectronStore usage
|
Any update on this? @rabrowne85 @manojVivek |
No real update - there is one outstanding issue that I've had on the back burner which is keeping the views in sync with each other. For some reason the browser sync package is no longer keeping things together and there's no obvious reason why not. I'll try and get a couple of hours on it this morning 👍 |
# Conflicts: # desktop-app/package.json # desktop-app/src/renderer/components/Button/index.tsx # desktop-app/src/renderer/components/Previewer/Device/Toolbar.tsx
|
@manojVivek I've managed to get the preload to work and as such the browserSync also works. I see that the I've merged the current Think the main "breaking changes" are going to be from the electron update, i.e., macOS 11 or older are no longer supported. Do you want to go to v2.x or v1.18.x? |
|
@manojVivek Any thoughts on the questions of whether to go v2 and/or adjust the config of the GitHub action? Would be good to get this in for review and merged 👍 |
✨ Pull Request
📓 Referenced Issue
There is no specific issue that directly prompted this PR, but it includes a fix for:
ℹ️ About the PR
This PR updates all project dependencies to their latest compatible versions, as resolved by the package manager.
Key changes include:
While no breaking changes have been identified so far, due to the broad scope of dependency updates, this might be best classified as a minor version bump. Please advise if a major version is more appropriate.
Note: The project does not appear to have a comprehensive test suite, though
npm run testcompletes successfully. 🤷♂️🖼️ Testing Scenarios / Screenshots
The following commands were run to validate the changes:
npm run startnpm run buildnpm run packagenpm run testWhile the test script completes, it's unclear how much coverage it provides.
Screenshots to follow
Items Outstanding