Fixing Set-to-data shortkey #3526
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notxvilka
requested changes
Nov 14, 2025
amibranch
force-pushed
the
fix_set_to_data_shortcut
branch
2 times, most recently
from
1ee042c to
6187d45
Compare
wargio
reviewed
Nov 16, 2025
wargio
reviewed
Nov 16, 2025
The underlying functionality makes it possible to switch a certain memory in Cutters Disassembly-view to data (via the shortcut `d`). This functionality is comparable to other similar products. The functionality already existed in cutter. Unfortunately it was broken due to two problems: * The underlying action was not added to a widget - this is now fixed, by adding it to the `setToDataMenu` - like other related actions * If the underlying meta was not prevously data, it simply just ignored the action, as the size of the data returned uninitilialized memory. This is now fixed. Returning 0 from `CutterCore::sizeofDataMeta` by default indicating that the Meta at the address is not data.
amibranch
force-pushed
the
fix_set_to_data_shortcut
branch
from
6187d45 to
333e035
Compare
notxvilka
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying functionality makes it possible to switch a certain memory in Cutter to data (via the shortcut
d). This functionality is comparable to other similar products. The functionality already existed in cutter. Unfortunately it was broken due to two problems:setToDataMenu- like other related actionsCutterCore::sizeofDataMetaindicates that the Meta at the address is currently no data.This change fixes the problem
Your checklist for this pull request
Detailed description
Please note: the problem was observed, by using Arch Linux with Sway and qt6-base version 6.10.0. If the described problem is not observed on other systems: please provide this as feedback so the change can be limited!
Test plan (required)
Load a binary and simply press "d"-key (multiple times) at a memory-location that was not data before.
Closing issues