WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Dec 30, 2025

@eregon eregon force-pushed the method_source_location_from_4_1 branch from 05a208f to f6ab2f9 Compare December 30, 2025 11:36
eregon added a commit to eregon/ruby that referenced this pull request Dec 30, 2025
@eregon
Copy link
Member Author

eregon commented Dec 30, 2025

This doesn't work in CRuby CI, see https://github.com/ruby/ruby/actions/runs/20595820151/job/59150151742?pr=15580
What should I do then?
Exclude the tests with tool/rbs_skip_tests?
Or rebase this on top of 3.10.0 since the failures might be caused by other changes on master?

@eregon
Copy link
Member Author

eregon commented Dec 30, 2025

From #1203 (comment)

Generally, the core library RBS definition targets the latest release of Ruby.

So if that's still the case, and it seems to be according to docs then I should use tool/rbs_skip_tests I guess.
Those docs should mention that then.

BTW these errors mention

💡You can skip this test test_each_paragraph(RBS::AST::Ruby::CommentBlockTest) by adding the name to /home/runner/work/ruby/ruby/src/tool/rbs_skip_tests

But these errors don't.

I also wonder if it's good to run RBS tests related to the core library in ruby/ruby CI since we know at least some of them will fail, so not sure there is much value.
This repo seems to test against ruby-head, not sure how that works though then given those differences.

@soutaro
Copy link
Member

soutaro commented Jan 6, 2026

@eregon Hi! Sorry for the late reply.

We’ve discussed the idea of moving the RBS definitions for core/stdlib classes into the ruby/ruby repository, so that committers can fix method types and their tests together with the Ruby implementation. I’m confident we’ll do this, though probably not within the next few weeks. (Maybe within months...)

For the current core/stdlib test failures, please use rbs_skip_tests in ruby/ruby. I’ll update the documentation as you suggested.

The bundled version of RBS is 3.10, but the master branch targets RBS 4.0 (unreleased), which is causing the CommentBlockTest failure. (Though I’m still not sure why.)

@eregon
Copy link
Member Author

eregon commented Jan 6, 2026

We’ve discussed the idea of moving the RBS definitions for core/stdlib classes into the ruby/ruby repository, so that committers can fix method types and their tests together with the Ruby implementation. I’m confident we’ll do this, though probably not within the next few weeks. (Maybe within months...)

That would be great!

For the current core/stdlib test failures, please use rbs_skip_tests in ruby/ruby.

Right, it's what I did.

I’ll update the documentation as you suggested.

Thanks!

@eregon
Copy link
Member Author

eregon commented Jan 6, 2026

This repo seems to test against ruby-head, not sure how that works though then given those differences.

Any insight on this? At first sight it seems weird that rbs master + ruby master works in ruby/rbs CI but not in ruby/ruby CI. I suppose they run different tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants