WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Jan 28, 2025

Additional fixes to support the seqFISH v2 file format.

Changelog

  • improved parsing of OME XML metadata
  • automatically parsing images as multiscale when they are larger than a threshold
  • allowing arbitrary strings as ROIs prefixes
  • now representing different ROIs in different coordinate systems
  • parsing z coordinate for points
  • fixed bug with indices of shapes when multiple rois were considered

CC @LLehner @adamdingliang

@LucaMarconato
Copy link
Member Author

I'm going through old stale PRs. Fixed the conflicts and merging now! CC @adamdingliang

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.30%. Comparing base (26fb99b) to head (6592674).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/seqfish.py 81.96% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   55.07%   55.30%   +0.23%     
==========================================
  Files          26       26              
  Lines        2809     2846      +37     
==========================================
+ Hits         1547     1574      +27     
- Misses       1262     1272      +10     
Files with missing lines Coverage Δ
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)
src/spatialdata_io/readers/_utils/_utils.py 31.46% <100.00%> (+0.77%) ⬆️
src/spatialdata_io/readers/seqfish.py 89.28% <81.96%> (-5.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato merged commit 5f829f5 into main Jan 6, 2026
5 checks passed
@LucaMarconato LucaMarconato deleted the seqfish-v2-fixes branch January 6, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants