Add blob upload example #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariria
reviewed
Oct 13, 2025
Contributor
hariria
left a comment
hariria
left a comment
There was a problem hiding this comment.
Looks great, some comments
apps/upload-blob/package-lock.json
Outdated
Contributor
There was a problem hiding this comment.
I think you might have npm installed instead of pnpm
Contributor
There was a problem hiding this comment.
Not sure if you saw this comment earlier so flagging it here
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
hariria
reviewed
Oct 13, 2025
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
Contributor
|
You need to remove the package-lock.json |
hariria
approved these changes
Oct 13, 2025
Contributor
hariria
left a comment
hariria
left a comment
There was a problem hiding this comment.
Thanks LGTM. I forgot to mention this in the previous pr but would you mind changing the package name of the download example to @shelby-protocol/download-example just to be consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.