Revert .css => .styles.ts
#1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lindsaym-fa
requested changes
Dec 10, 2025
Contributor
lindsaym-fa
left a comment
lindsaym-fa
left a comment
There was a problem hiding this comment.
styles/utilities/size.css and styles/utilities/variants.css were both imported in native styles, so these are the results we're getting for native buttons and such now:
I'd recommend:
- Moving
size.styles.tsandvariants.styles.tsto thestyles/component/directory - Restoring
size.cssandvariants.cssin thestyles/utilities/directory and removing the:host()selector for each rule in these files
Does that make sense to you, @claviska? (And let me know if you'd like me to make those changes.)
Member
Author
|
@lindsaym-fa nice catch. It looks like the visually hidden utilities were also affected so I updated those as well. Let me know if you see anything else! |
Member
Author
|
Note: I also removed the |
lindsaym-fa
reviewed
Dec 10, 2025
Contributor
lindsaym-fa
left a comment
lindsaym-fa
left a comment
There was a problem hiding this comment.
One small comment. All else looks good!
lindsaym-fa
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1812 by reverting the component CSS files to Lit's preferred syntax. Since this updates the base class, I'll update pro after this is merged.