-
-
Notifications
You must be signed in to change notification settings - Fork 102
Support more MathML attributes and other math fixes and enhancements #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Omikhleia
wants to merge
15
commits into
master
Choose a base branch
from
omi-math-next-experiment-14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+660
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placing an accent (say `\bar`) over a single macro-defined command
(say a `\Phi`, or a `\mathbf{x}`) caused the engine to crash.
The accent logic was incorrectly re-compiling the already compiled
argument recursively. We were just lucky in other cases.
…ithout losing content
Math formula in block quotes, footnotes, headers, etc. now adapt to the current document size instead of using a fixed value. The adjustment is based on the eye (ex-height) for consistent optical alignment.
Mere typo seen in passing, only affecting debug.
…a macro The columnalign option is modified (converted to list), but might be the same original object from a TeX-like macro. One invocation of the macro shall not affect the subsequent one.
The "cap" unit is proposed in CSS4 Draft and makes sense for cap-height font adjustement. Both "ex" and "cap" shall be based on font metrics when available, and only measure a character as a fallback heuristic. Some fonts may not have the necessary Latin characters, in which case we shall resorti to a decent fallback (as per CSS recommendations).
The original version only parsed a subset of the table. Let's handle the complete OS/2 font table for all versions 0 to 5.
5191c2f to
a60c989
Compare
a60c989 to
d33b285
Compare
20 tasks
…cands Default text style shouldn't be cramped. Radicands in roots shoud trigger cramping.
4d63a9e to
5c44d42
Compare
Supporting `\sqrt[degree]{radicand}` requires support from the parser
due to the unusual syntax with a math expression between square brackets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY FOR MERGE
Based on a temporary branch with cherry-picked commits from several other of my PRs for 0.15.14
WIP Additions:
fix(math): Properly apply 'cramping' styles in text mode and for radicands= see Math improperly "cramped" #2341 EDIT: Moved to its own PR fix(math): Properly apply 'cramping' styles in text mode and for radicands #2345