WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@vipin8797
Copy link

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

The file packages/engine.io/lib/transports/websocket.ts contains a few minor comment formatting inconsistencies:

  • Comments starting in lowercase
  • Missing periods for sentence-like comments
  • Inconsistent formatting in multi-line comments

New behavior

This PR improves comment formatting in websocket.ts:

  • Capitalized comment beginnings
  • Added missing periods
  • Improved clarity of multi-line comments

No functional or behavioral changes were introduced.

Other information

This is a small internal cleanup PR.
よろしくお願いします!

@darrachequesne
Copy link
Member

Hi! Thanks for the pull request 👍

However, these are mainly small nitpicks that don't provide much value overall, so I'm closing this. Thank you for your comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants