WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Hitlinemoss
Copy link
Contributor

@Hitlinemoss Hitlinemoss commented Dec 8, 2025

About the PR

Reorganizes several job-related files (see technical details). This is all backend code cleanup for the most part, though I also took the time to fix the fact that there wasn't an actual prototype for the senior courier ID card like for other senior jobs' ID cards.

Why / Balance

Organized code good. This makes it much easier to find any specific job in these files, since instead of needing to scroll through massive unsorted lists you just go to the appropriate section.

For future reference, here's the typical ordering I use to sort files like this:

  • Command
    • Department heads go here despite also being members of their subordinate departments
    • For station beacons specifically I put AI in its own section after this since it's a highly specific Command-restricted area
  • Cargo
  • Engineering
  • Medical
  • Science
  • Security
  • Service
  • Silicon
  • Visitors
  • CentComm / ERT
    • These are grouped together since the ERT is technically a part of CentComm.
  • Antagonists
  • Other
    • This can sometimes be broken off into its own groups if necessary (e.g figurines having an "Animals" category).

Technical details

  • Files related to figurines (locale, datasets, prototypes) are all now sorted by department
  • Job description locale file is now sorted by department
  • Files related to station beacons (locale, prototypes) are all now sorted by department
  • PDA prototype file is now sorted by department
  • ID card prototype file is now sorted by department
  • Added SeniorCourierIDCard entity prototype
  • Added SeniorCourier.png to job_icons.rsi

Media

moss-sortjobdatasets

Requirements

Breaking changes

N/A

Changelog

🆑

  • fix: Senior courier ID cards now have a unique job icon, as with other senior jobs.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/L Denotes a PR that changes 1000-4999 lines. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

RSI Diff Bot; head commit 6438520 merging into 92482df
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/job_icons.rsi

State Old New Status
SeniorCourier Added

Edit: diff updated after 6438520

@Hitlinemoss Hitlinemoss changed the title Assorted cleanups of job-related files Assorted organization of job-related files + fixed senior courier ID missing a job icon Dec 8, 2025
…on-14 into moss-sortjobdatasets

Merge master into branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants