docs: add VMO cluster deployment DOC-1358 #46
Conversation
addetz
requested review from
achuribooks,
karl-cardenas-coding and
lennessyy
and removed request for
a team
addetz
force-pushed
the
add-vmo-cluster-doc-1358
branch
10 times, most recently
from
c127eb5 to
d1ac9fe
Compare
docs: add creation of virtual machine docs: add test cases DOC-1358 docs: add readme DOC-1358
addetz
force-pushed
the
add-vmo-cluster-doc-1358
branch
from
d1ac9fe to
4698a97
Compare
caroldelwing
left a comment
caroldelwing
left a comment
There was a problem hiding this comment.
Congratulations on making this configuration work 👏 This will really help our users.
Also the test cases cover everything we need 🚀
addetz
left a comment
addetz
left a comment
There was a problem hiding this comment.
I can only comment on my own PR 😆 My main question is around the templating of the manifest files at this point.
| instance_type { | ||
| min_cpu = var.ctl-node-min-cpu | ||
| min_memory_mb = var.ctl-node-min-memory-mb | ||
| } |
There was a problem hiding this comment.
Suggest name variables using the same format. Something like maas-control-node-min-cpu and maas-control-node-min-memory-mb.
| instance_type { | ||
| min_cpu = var.wrk-node-min-cpu | ||
| min_memory_mb = var.wrk-node-min-memory-mb | ||
| } |
There was a problem hiding this comment.
Same comment about the naming. maas-worker-node-min-cpu and maas-worker-node-min-memory-mb
terraform/vmo-cluster/data.tf
Outdated
| data "spectrocloud_cluster" "maas_vmo_cluster" { | ||
| count = var.deploy-maas-vm ? 1 : 0 | ||
| depends_on = [spectrocloud_cluster_maas.maas-cluster] | ||
| name = "vmo-cluster-maas" |
There was a problem hiding this comment.
This needs to use the var as well now that you have provided one.
terraform/vmo-cluster/inputs.tf
Outdated
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Delete these empty lines?
terraform/vmo-cluster/inputs.tf
Outdated
|
|
||
| variable "cluster-profile-type" { | ||
| type = string | ||
| description = "The name of the PCG that will be used to deploy the cluster." |
There was a problem hiding this comment.
The description is copy-pasta.
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
| vm-storage-Gi = "50Gi" # Size of the disk (PVC) that your VM will have. | ||
| vm-cpu-cores = 2 # Number of CPU cores your VM will have. | ||
| vm-cpu-sockets = 1 # Number of physical CPU sockets the CPU cores should be spread over. | ||
| vm-cpu-threads = 2 # Number of CPU threads to use for the VM CPU | ||
| vm-memory-Gi = "4Gi" # Amount of RAM (memory) your VM will have |
There was a problem hiding this comment.
Should these be templated in the vmo-extras manifest?
| cluster_context = data.spectrocloud_cluster.maas_vmo_cluster[0].context | ||
|
|
||
| #run_on_launch = true | ||
| run_strategy = "Halted" |
There was a problem hiding this comment.
Does this still need to be Halted?
caroldelwing
left a comment
caroldelwing
left a comment
There was a problem hiding this comment.
PR reviewed :) Will approve it tomorrow after the suggestions are applied and we complete the tests.
| guest = var.vm-memory-Gi | ||
| } | ||
|
|
||
| resources {} |
There was a problem hiding this comment.
is this empty block required?
terraform/vmo-cluster/tests/virtual-machine-missing-values.tftest.hcl
Outdated
Show resolved
Hide resolved
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
3 participants
Describe the Change
This PR adds the VMO cluster deployment and VM creation example.
Review Changes
🎫 DOC-1358