Fix nested asterisks #244
Merged
Fix nested asterisks #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing bold text, it will search for an opening italicization (`*`). If it's found, it then tries to find an ending italicization. If that is found, then that text is skipped when searching for the closing `**` for the bold text.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
spenserblack
force-pushed
the
bugfix/233/nested-asterisks
branch
from
680f6a9 to
539fc3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to do
*foo **bar***(probably broken by a3fb3c9)***foo** bar*These 4 combos should be tested:
***foo* bar**[b][i]foo[/i] bar[/b]***foo** bar*[i][b]foo[/b] bar[/i]**foo *bar***[b]foo [i]bar[/i][/b]*foo **bar***[i]foo [b]bar[/b][/i]