WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@rlieberman-splunk
Copy link
Collaborator

Description

This PR updates the cluster setup for AWS EKS clusters, and the accompanying README for the script. The script now includes an option --no-eksctl for customers that setup their cluster and IRSA separately, but still want an automated script to setup the ai platform.

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement
  • CI/CD improvement
  • Chore (dependency updates, etc.)

Changes Made

  • eks_cluster_with_stack.sh: add new --no-eksctl option, only run eksctl commands if option is not present.
  • EKS_README.md: add instructions on what needs to be setup on the cluster before running the script if not using eksctl.

Testing Performed

  • Unit tests pass (make test)
  • Linting passes (make lint)
  • Integration tests pass (if applicable)
  • E2E tests pass (if applicable)
  • Manual testing performed

Test Environment

  • Kubernetes Version: 1.31
  • Cloud Provider: AWS
  • Deployment Method: eksctl (outside of the script)

Test Steps

  1. Created a cluster manually
  2. Used new steps in EKS_README.md to create required service accounts
  3. Ran CONFIG_FILE=./cluster-config.yaml ./eks_cluster_with_stack.sh install --no-eksctl and verified the system was setup.

Documentation

  • Updated inline code comments
  • Updated README.md (if adding features)
  • Updated API documentation
  • Updated deployment guides
  • Updated CHANGELOG.md
  • No documentation needed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have updated the Helm chart version (if applicable)
  • I have updated CRD schemas (if applicable)

Breaking Changes

Impact:

Migration Path:

Screenshots/Recordings

Additional Notes

Reviewer Notes


Commit Message Convention: This PR follows Conventional Commits

@coveralls
Copy link

coveralls commented Dec 11, 2025

Pull Request Test Coverage Report for Build 20148552881

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.822%

Totals Coverage Status
Change from base Build 20110660898: 0.0%
Covered Lines: 2336
Relevant Lines: 6344

💛 - Coveralls

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a --no-eksctl flag to the EKS cluster setup script, allowing users to set up the AI platform on pre-existing EKS clusters that were created outside of eksctl. The changes conditionally skip eksctl-dependent operations (OIDC provider setup, service account creation, and addon installation) when this flag is present, while providing clear error messages directing users to perform these setup steps manually.

Key Changes:

  • Added --no-eksctl command-line flag with argument parsing logic
  • Wrapped all eksctl commands in conditional blocks that check the USE_EKSCTL flag
  • Updated documentation with prerequisites for manual cluster setup without eksctl
  • Fixed unrelated bugs: corrected Splunk service name in port-forward command and removed non-existent status command

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
tools/cluster_setup/eks_cluster_with_stack.sh Added USE_EKSCTL flag and conditional logic around eksctl commands in OIDC setup, EBS CSI addon installation, service account creation, and preflight checks; added argument parsing for --no-eksctl flag
tools/cluster_setup/EKS_README.md Added comprehensive prerequisites for --no-eksctl mode including required IAM service accounts, policies, and cluster configuration; fixed Splunk service name; removed reference to non-existent status command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants