refactor(SSE): move static functions to extensions #9010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Aug 16, 2025
yschimke
reviewed
Aug 16, 2025
yschimke
reviewed
Aug 16, 2025
JakeWharton
reviewed
Aug 16, 2025
yschimke
approved these changes
Aug 30, 2025
Collaborator
|
@swankjesse requesting post API review. Seems like a good cleanup and more idiomatic Kotlin. |
hugoncosta
pushed a commit
to hugoncosta/okhttp
that referenced
this pull request
Aug 30, 2025
* refactor(SSE): move static functions to extensions
swankjesse
added a commit
that referenced
this pull request
Oct 2, 2025
This reverts commit 09fb9a4.
swankjesse
added a commit
that referenced
this pull request
Oct 2, 2025
This reverts commit 09fb9a4.
Collaborator
|
Reverted here. #9098 Discussion about why to revert on that PR. |
swankjesse
added a commit
that referenced
this pull request
Oct 2, 2025
This reverts commit 09fb9a4.
yschimke
pushed a commit
that referenced
this pull request
Oct 3, 2025
…9098) * Revert "refactor(SSE): move static functions to extensions (#9010)" This reverts commit 09fb9a4. * Remove unnecessary control flow from a test (#9099) Co-authored-by: Jesse Wilson <[email protected]> --------- Co-authored-by: Jesse Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some comments for
TODOblocks.for square/retrofit#4462