WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Make HttpException implement CopyableThrowable + add test #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ferinagy wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Make HttpException implement CopyableThrowable + add test #3475

ferinagy wants to merge 1 commit into from

Conversation

@ferinagy
Copy link

@ferinagy ferinagy commented Oct 5, 2020

Fixes #3474

ferinagy
ferinagy commented Oct 5, 2020
View reviewed changes
@ferinagy ferinagy mentioned this pull request Oct 5, 2020
Open
JakeWharton
JakeWharton reviewed Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately CopyableThrowable is not stable API so we cannot depend on it. As soon as it goes stable we can land this change.

@JakeWharton JakeWharton force-pushed the nagy/httpexception-await branch 2 times, most recently from 26638cb to f6cf0d5 Compare October 16, 2020 13:15
@iamarjun
Copy link

iamarjun commented Nov 3, 2022 •
edited
Loading

@ferinagy @frantisek-nagy just created a fork with your changes and it seems like I still don't get the stack trace of the call site, am I missing anything? Not sure how tests are working fine.

@ferinagy ferinagy force-pushed the nagy/httpexception-await branch from f6cf0d5 to 57e75a3 Compare November 21, 2022 09:26
@ferinagy
Copy link
Author

ferinagy commented Nov 21, 2022

@ferinagy @frantisek-nagy just created a fork with your changes and it seems like I still don't get the stack trace of the call site, am I missing anything? Not sure how tests are working fine.

Hi, maybe you are hitting this case? Kotlin/kotlinx.coroutines#2607

@iamarjun
Copy link

iamarjun commented Nov 21, 2022

@ferinagy @frantisek-nagy just created a fork with your changes and it seems like I still don't get the stack trace of the call site, am I missing anything? Not sure how tests are working fine.

Hi, maybe you are hitting this case? Kotlin/kotlinx.coroutines#2607

Oh, I see, any workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeWharton JakeWharton JakeWharton left review comments

+1 more reviewer

@Goooler Goooler Goooler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using suspending async/await, stacktrace contains no application code

5 participants

@ferinagy @iamarjun @JakeWharton @Goooler @frantisek-nagy