WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@kaushal-kumar-it
Copy link
Contributor

@kaushal-kumar-it kaushal-kumar-it commented Nov 6, 2025

Resolves #8253.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes JavaScript lint errors in the package by correcting the example to reference only valid files and ensuring that the implementation passes all ESLint checks.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 6, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 6, 2025

Coverage Report

Package Statements Branches Functions Lines
utils/async/for-each-right $\color{green}530/530$
$color{green}+100.00%$
$\color{green}59/59$
$color{green}+100.00%$
$\color{green}8/8$
$color{green}+100.00%$
$\color{green}530/530$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 6, 2025

@kaushal-kumar-it Please consult the development guide. You are not properly branching. This PR contains unrelated changes.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 6, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 7, 2025
@kgryte kgryte merged commit cd0d010 into stdlib-js:develop Dec 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants