-
Notifications
You must be signed in to change notification settings - Fork 17
feat(cli): config system #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
non-availability early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 1
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
- Restructure for clarity - Add Layering explanation - Table reference
@storyblok/astro
storyblok
@storyblok/eslint-config
@storyblok/js
storyblok-js-client
@storyblok/management-api-client
@storyblok/nuxt
@storyblok/react
@storyblok/region-helper
@storyblok/richtext
@storyblok/svelte
@storyblok/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
maoberlehner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is mostly straightforward to follow, and the tests help to further understand what's happening.
Left a couple of mostly minor comments.
handled by the logger
maoberlehner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of non-blocking thoughts and nitpicks, but I think the PR is ready for merge as is.
Follow up of #347 as per @alvarosabu suggestion.
Remaining work:
mainNote
Introduces a layered config system resolved at runtime and applied across global CLI flags, logging/reporting, and API concurrency/retry, with minor command defaults and exports.
~/.storyblok/config.*,.storyblok/config.*,storyblok.config.*) withc12.lib/config/*(defaults, loader, resolver, commander integration, store) and typeddefineConfigAPI.storyblok/configexportingdefineConfigand types; comprehensive README.--region,--verbose,--api-max-*,--log-*,--ui-enabled,--report-*) with hyphen-based path parsing and--no-*support.programpreAction; hydrate commands; expose active config.api.ts: rate limiter capacity now derives from active config (api.maxConcurrency).utils/fetch.ts: retries derive from config (api.maxRetries).directories.components|datasourcesconstants.unbuild; package exports/types updated; switch todotenv/config.c12; lockfile updates.Written by Cursor Bugbot for commit 6627674. This will update automatically on new commits. Configure here.