Fix media url in data tab #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ListBuilder/DynamicListBuilder.php
Outdated
| if (null === $this->downloadUrl) { | ||
| // The given id must be a number which we replace | ||
| $idReplacerNumber = '875421'; | ||
| $localeToReplace = 'en'; |
Member
There was a problem hiding this comment.
use {locale} or __locale__ here:
Suggested change
| $localeToReplace = 'en'; | |
| $localeToReplace = '{locale}'; |
The en is not unique enough here. If somebody change the admin url to a domain which may contains en letters or a directory it would replace that also. So you need something more unique like {locale}.
you might still need str replace url encoded version of $localeToReplace not sure if symfony router use raw url encode or url encode.
alexander-schranz
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use media redirect route to fix media url in data tab.