WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Removes wrong "optional" argument information for sulu_categories #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FlxRobole wants to merge 36 commits into
base: 2.5
Choose a base branch
from
Open

Removes wrong "optional" argument information for sulu_categories #811

FlxRobole wants to merge 36 commits into from

Conversation

@FlxRobole
Copy link

@FlxRobole FlxRobole commented Jul 9, 2024

Q A
License MIT

What's in this PR?

  • Removes wrong information about optional argument locale in sulu_categories twig extension
  • Adds type information in arguments section

Why?

Not passing the locale argument throws an error as it is mandatory (see code)

vinceAmstoutz and others added 30 commits November 25, 2022 13:33
@vinceAmstoutz
Add support for avif image formats (sulu#755)
91d7e0d
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
ddaaa7b
@alexander-schranz
Add comment about Symfony 5 for anonymous flag (sulu#758)
3fe85af
@alexander-schranz
Add missing provider sulu (sulu#759)
88ec73b
@alexander-schranz
Fix azure blob storage connection_string (sulu#760)
f5ac3c8
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
95f0c27
@matthiasseghers
Fix invalid YAML syntax (sulu#768)
874af76
@remdan
Add controller.service_arguments tag (sulu#769)
5695af2
@matthiasseghers
Add custom sorting documentation (sulu#770)
bc507fb
@mamazu
Add documentation for sulu-link "remove-if-not-exists" (sulu#773)
25c9f6f
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
97ac534
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
04a8a07
@alexander-schranz
Fix html code blocks in link docs (sulu#783)
93c8613
@alexander-schranz
Add hint to use bun to build admin (sulu#782)
b01584c
@Prokyonn
Add documentation for snippet area cache settings (sulu#788)
8b4a385
@martinlagler
Add mapquest to location documentation (sulu#789)
bf0a10a
@wachterjohannes @Prokyonn
Add documentation for global-blocks (sulu#787)
6093d42 
* add documentation for global-blocks

* fix code-block

* fix code-review

* Update book/templates.rst

Co-authored-by: Prokyonn <[email protected]>

---------

Co-authored-by: Prokyonn <[email protected]>
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
db4f946
@TheCadien @Prokyonn
Extend Docs for Admin View Debug Command (sulu#793)
7e7603f 
* Extend Docs for Admin View Debug Command

* Update book/extend-admin.rst

Co-authored-by: Prokyonn <[email protected]>

---------

Co-authored-by: Prokyonn <[email protected]>
@Prokyonn
Add reference bundle documentation (sulu#795)
67a3c6a 
* Add reference bundle docs

* Add review suggestion

* Add review suggestion
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
2e197e8
@wachterjohannes @Prokyonn
Add cleanup phpcr database (sulu#791)
7b3228b 
* add cleanup phpcr database

* Apply suggestions from code review

Co-authored-by: Prokyonn <[email protected]>

---------

Co-authored-by: Prokyonn <[email protected]>
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
2d09555
@martinlagler
Add single sign on documentation (sulu#792)
45b5a6b
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.x
8c49c28
@alexander-schranz
Bump Version
d513a63
@alexander-schranz
Update requirements for Sulu 2.6 (sulu#799)
43af68c
@alexander-schranz
Fix some basic docs styling
d671cd9
@alexander-schranz
Merge branch '2.5' of github.com:sulu/sulu-docs into 2.6
ef86dac
@alexander-schranz
Fix refernce bundle paragraph spaces (sulu#801)
beb04cc
@alexander-schranz
Copy link
Member

alexander-schranz commented Feb 6, 2025

@FlxRobole thx, can you target the current 2.5 branch for this fix?

@FlxRobole FlxRobole changed the base branch from 2.6 to 2.5 February 10, 2025 07:53
@FlxRobole
Copy link
Author

FlxRobole commented Feb 10, 2025

@alexander-schranz base branch updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@FlxRobole @alexander-schranz @vinceAmstoutz @matthiasseghers @remdan @mamazu @Prokyonn @martinlagler @wachterjohannes @TheCadien