feat: Add email send operation metrics #2311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new metrics, gotrue_email_send_operations_counter_total and gotrue_email_send_errors_counter_total, for tracking email send operations and errors respectively. The purpose of these metrics is to track email delivery independently of the various API handlers that may send email within Auth.
Pull Request Test Coverage Report for Build 20666067842Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds two new metrics,
gotrue_email_send_operations_counter_totalandgotrue_email_send_errors_counter_total, for tracking email send operations and errors respectively. The purpose of these metrics is to track email delivery independently of the various API handlers that may send email within Auth.What is the current behavior?
Users who want to track email sending operations in Auth must use indirect metrics like HTTP status codes to determine whether an email was successfully sent.
What is the new behavior?
The
gotrue_email_send_operations_counter_totalcounter will increment each time Auth attempts to send an email after performing validation and checking rate limits. Thegotrue_email_send_errors_counter_totalcounter will increment each time an email send attempt fails.