WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@gordysc
Copy link

@gordysc gordysc commented Dec 18, 2025

Fixes #14987

When preloading a route via data-sveltekit-preload-data="hover" and then navigating to a different route, the preload fork was not being discarded. This caused the orphan fork to interfere with subsequent DOM updates, resulting in the URL changing but page content remaining stale - particularly noticeable when navigating between routes with different layouts.

The issue was at line 1696 in client.js: when the navigation intent didn't match the preloaded route's ID, we correctly set load_cache_fork = null but only cleared the load_cache reference with load_cache = null. This failed to call fork.discard() on the orphan fork.

The fix conditionally calls discard_load_cache() (which properly discards the fork) when we're not using the preloaded fork, instead of just clearing the reference.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 5cc8f7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hmnd
Copy link
Contributor

hmnd commented Dec 19, 2025

Much needed fix! There's also this related underlying issue too sveltejs/svelte#17335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link triggers URL change, but layout/component doesn't rerender

3 participants