Discard preload fork when navigating to a different route #15071
+113
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14987
When preloading a route via
data-sveltekit-preload-data="hover"and then navigating to a different route, the preload fork was not being discarded. This caused the orphan fork to interfere with subsequent DOM updates, resulting in the URL changing but page content remaining stale - particularly noticeable when navigating between routes with different layouts.The issue was at line 1696 in
client.js: when the navigation intent didn't match the preloaded route's ID, we correctly setload_cache_fork = nullbut only cleared theload_cachereference withload_cache = null. This failed to callfork.discard()on the orphan fork.The fix conditionally calls
discard_load_cache()(which properly discards the fork) when we're not using the preloaded fork, instead of just clearing the reference.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits