-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix mention of CompilerPassInterface support for bundles
#21642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mention of CompilerPassInterface support for bundles
#21642
Conversation
CompilerPassInterface support for bundlesCompilerPassInterface support for bundles
|
Thinking a bit more about it, maybe it's not necessary to remove this documentation. Instead, we can just add a few lines to make it work: class MyBundle extends AbstractBundle implements CompilerPassInterface
{
public function process(ContainerBuilder $container): void
{
// ...
}
public function build(ContainerBuilder $container): void
{
$container->addCompilerPass($this); // self-registration
}
}Then, in 8.1 we can just remove the |
|
Ah didn’t even think about this; but yes this feels like a pretty good alternative 👍 |
f367350 to
f4cc93c
Compare
CompilerPassInterface support for bundlesCompilerPassInterface support for bundles
|
PR updated. Not sure about the call to |
it's not required, you can safely remove it |
f4cc93c to
d4bfcb2
Compare
yceruto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thank you Mathieu. |
|
This is now merged, without any changes, in all upper branches up to 8.1. Folks, please tell me if we need to do any change in 8.1 or ny other branch. Thanks! |
Following #20365 (comment)