Normative: DoWait byteIndexInBuffer is miscalculated #3724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
force-pushed
the
fix/do-wait-byte-index-in-buffer
branch
from
4aa5d75 to
4bde5d3
Compare
michaelficarra
approved these changes
Nov 17, 2025
bakkot
approved these changes
Dec 1, 2025
Contributor
|
Good catch, that's indeed a bug. |
syg
approved these changes
Dec 1, 2025
bakkot
added
the
ready to merge
ljharb
changed the title
ljharb
added
normative change
ljharb
force-pushed
the
fix/do-wait-byte-index-in-buffer
branch
from
4bde5d3 to
4d2116b
Compare
github-actions
bot
removed
the
request preview
|
The rendered spec for this PR is available at https://tc39.es/ecma262/pr/3724. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug has slipped into the
DoWaitmethod of Atomics: theValidateAtomicAccessalready returns the "byte index in buffer" value (see for instance the Atomics.notify method step 2). InDoWaitwe instead assume that it returns an index into anInt32Arrayand later perform the byte multiplication and offsetting manually on top of the value. This is of course entirely wrong and would only work if the original index and offsets are both 0.