Add tests for not calling well-known symbols on primitives for string methods #4404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 18, 2025
test/built-ins/String/prototype/match/cstm-matcher-on-bigint-primitive.js
Show resolved
Hide resolved
test/built-ins/String/prototype/match/cstm-matcher-on-boolean-primitive.js
Show resolved
Hide resolved
test/built-ins/String/prototype/match/cstm-matcher-on-number-primitive.js
Outdated
Show resolved
Hide resolved
ljharb
reviewed
Feb 18, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
for Symbol.match, what about new RegExp?
Member
Author
|
The normative PR does not change the behaviour of the regexp constructor. It already only gets |
Member
|
aha, then the normative PR has an even stronger case in favor of it :-) |
ljharb
approved these changes
Feb 18, 2025
Ms2ger
changed the title
ptomato
approved these changes
Feb 28, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Seems good. Any value for implementations in being exhaustive and adding tests for Symbol primitives as well? I'm leaning towards no.
Member
Author
|
Agree |
ptomato
force-pushed
the
dont_call_wellknown_for_primitives
branch
from
85a4d36 to
2e5808e
Compare
Contributor
|
The normative change has consensus and there were no further comments from implementations. I think we should merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#3009