refactor: make php language injector play nice with phpdocs

[xHeaven]

Closes #14.

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[xHeaven]

@xepozz Does this look fine?

[xepozz]

Thanks @xHeaven. I've tried to perform such collecting, but nothing worked.
The way is simple:

• Target to a File in Injector
• Find XmlValue/etc manually with PsiTreeUtil
• Inject as it is now

But PHP layer don't work in this way, all completion is broken.

I've pushed a minor refactoring, I'm ok to merge it.

[xepozz]

The picture I attached to the previous post is related to the web types. Lets disable injections from the web types / symbols, they block our manual injection. Can you check?

[xepozz]

With enabled web types. It blocks autocompletion, inspections

[xHeaven]

Interesting, which one do you think holds more value as it is right now, web types or autocomplete?

With web types, we have less autocomplete, but the IDE is less of a Christmas tree.
Without web types, we get autocomplete along with all kinds of issues such as syntax errors and attribute warnings:

We also have a weird issue where we type the variable called $item wrongfully for no apparent reason - not introduced in this PR but weird regardless:

I'm not sure we should disable web types just to make the feature in OP work, more like we should fix the behavior of web types, but that's out of the scope of this PR.

We could probably do either:

• wait with merging this PR, find a solution for the web types issue and merge later
• merge regardless (autocomplete still works outside of Tempest built-in attributes), and find a solution for the web types issue later

What are your thoughts?