RedfishClientPkg: Redfish task service support #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new library to handle Redfish message. This library associate Redfish message to corresponding Redfish URI. When Redfish resource is ready for provisioning, driver can get all Redfish messages associated with this Redfish URI and add them into provision data. Signed-off-by: Nickle Wang <[email protected]>
…tate Introduce new library of updating Redfish task state to BMC. The interface between host and BMC for updating Redfish task state is not defined in industrial specification. Since this depends on platform BMC implementation, this library is created for platform owner to handle this part. Signed-off-by: Nickle Wang <[email protected]>
nicklela
force-pushed
the
redfish-task-support
branch
from
72422bd to
269641a
Compare
Add new library to read Redfish protocol feature attribute. Redfish feature driver calls this library to get protocol feature support on BMC. Signed-off-by: Nickle Wang <[email protected]>
nicklela
force-pushed
the
redfish-task-support
branch
2 times, most recently
from
fecbecc to
62a3d74
Compare
… task Introduce new driver to handle Redfish task service. This driver reads Redfish task service and dispatch task to registered Redfish driver. When Redfish driver is done with his job, this driver helps to return task result back to BMC. Signed-off-by: Nickle Wang <[email protected]>
Add special handing for Redfish task service because task needs to be called before Redfish feature driver. The request from Redfish task may change the BIOS configuration so it has to be handled first. Signed-off-by: Nickle Wang <[email protected]>
Enable Redfish task support by adding RedfishTaskDxe driver, Redfish message library and Redfish task library to RedfishClientPkg. Signed-off-by: Nickle Wang <[email protected]>
nicklela
force-pushed
the
redfish-task-support
branch
from
62a3d74 to
5881f20
Compare
ghbaccount
reviewed
Nov 2, 2024
| while (!IsNull (&Private->RegisteredList, Node)) { | ||
| Entry = REDFISH_TASK_REGISTERED_ENTRY_FROM_LIST (Node); | ||
|
|
||
| if ((StrCmp (Entry->ListenUri, Uri) == 0) && (Entry->Context == Context)) { |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to check Context value at first?
ghbaccount
reviewed
Nov 2, 2024
| JsonValueFree (TaskCollection); | ||
| } | ||
|
|
||
| return Status; |
Contributor
There was a problem hiding this comment.
@nicklela, there is a compilation warning:
RedfishClientPkg/RedfishTaskServiceDxe/RedfishTaskServiceDxe.c:496:10: error: 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized]
return Status;
^~~~~~
cc1: all warnings being treated as errors.
Contributor
Author
|
I need more time to create flow diagram and explain how Redfish task works. So I convert this pull request to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce driver and library to support Redfish task service.
How This Was Tested
Build pass on RedfishClientPkg.