DynamicTablesPkg/AmlLib: Remove invalid ASSERT for IRQ macro generation #11855
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
pierregondois and
samimujawar
abdattar
force-pushed
the
IrqAssertFix
branch
from
52c323d to
87d3a4f
Compare
The ACPI specification does not require legacy IRQs (x86) to be ActiveLow when EdgeTriggered or vice-versa. Hence the ASSERT checking for ActiveLow when EdgeTriggered is removed for IRQ macro generation non-ARM architecture. The IRQNoFlags macro defaults to EdgeTrigger and ActiveHigh configuration, demonstrating that this combination is valid. Reference: ACPI Specification 6.5 - Section 19.6.66: IRQ (Interrupt Resource Descriptor Macro) - Section 19.6.67: IRQNoFlags (Interrupt Resource Descriptor Macro) Signed-off-by: Abdul Lateef Attar <[email protected]>
abdattar
force-pushed
the
IrqAssertFix
branch
from
87d3a4f to
f7f7b70
Compare
pierregondois
approved these changes
Dec 9, 2025
Merge Queue Status✅ The pull request has been merged at 354e5a9 This pull request spent 13 minutes 9 seconds in the queue, including 13 minutes running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACPI specification does not require legacy IRQs (x86) to be ActiveLow when EdgeTriggered or vice-versa.
Hence the ASSERT checking for ActiveLow when EdgeTriggered is removed for IRQ macro generation.
The IRQNoFlags macro defaults to EdgeTrigger and ActiveHigh configuration, demonstrating that this combination is valid.
Reference: ACPI Specification 6.5
Description
How This Was Tested
Tested on AMD platform.
Integration Instructions
N/A