Global: Demonstrate/Test CLANGPDB CI #11860
Draft
+47
−257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebeaton
force-pushed
the
ci-clangpdb
branch
5 times, most recently
from
afb9e9d to
af06f2a
Compare
The compiler is not spotting that the inverse of the same conditions has already been checked, therefore either the 'if' or the 'else if' has to happen. On the other hand, it is misleading coding to use 'else if' for something that has to happen given earlier checks. This fixes the misleading coding and the warning. We definitely want to keep the warning enabled, as it has caught several genuine cases of uninitialized use. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
force-pushed
the
ci-clangpdb
branch
5 times, most recently
from
db0ebb1 to
3a45dcb
Compare
From experimentation, for RedfishPkg to compile using CLANGPDB we need to both apply the GLOBAL_USED macro found in SecurityPlg and CryptoPkg, and make an external refernce to _fltused inside each library which needs it. Without both these changes, aggressive LTO optimization is presumably deciding that _fltused is not needed even though by the time we finally come to link it is, and both these libraries fail with: lld-link: error: undefined symbol: _fltused Signed-off-by: Mike Beaton <[email protected]>
THIS IS A TEST COMMIT - DO NOT MERGE Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
force-pushed
the
ci-clangpdb
branch
from
3a45dcb to
a13a459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS IS A TEST COMMIT - DO NOT MERGE
How This Was Tested
CI
Integration Instructions
N/A