feat: add cjdk to allow it all to work without any java or maven installed #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
changed the title
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This was referenced Apr 20, 2025
Draft
Owner
Author
|
this work was upstreamed to scyjava in scijava/scyjava#80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to allow
pip install bffile(or whatever we call it), to Just Work® even if java and maven is not installed on the system. An explanation of how this works is added to the readme hereTests are added to test that we work both with a system installed java (via
actions/setup-java) as well as a cjdk-installed version (whenjava-version = ''). This also adds a test on bioformats-version 6.0.1The autoused
cache_dirsfixture inconftest.pyensures that tests don't have side effects: both that they don't unexpectedly pass due to a resource found in the testers environment, or leave any residual files on the testers user space. (unless opted into with--allow-cacheto speed it all up)@ctrueden, would be great if you could have a look at this when you have a moment (and @marktsuchida... if you want to verify my usage of cjdk)