fix(optimizer)!: query schema directly when type annotation fails for processing UNNEST source #6451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
can you fix the type annotation instead? |
Collaborator
|
Yeah, I second that suggestion in favor of avoiding making this more complicated than necessary. Keen to understand more if that is tricky to do; let me know and we can hop in a call and chat about this. |
georgesittas
reviewed
Dec 3, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
@fivetran-BradfordPaskewitz keep in mind that you'll need to rebase and apply these changes to resolver.py due to 625654a.
fivetran-BradfordPaskewitz
force-pushed
the
fix_qualify_unnest
branch
2 times, most recently
from
3b0a522 to
fea0204
Compare
georgesittas
reviewed
Dec 8, 2025
fivetran-BradfordPaskewitz
force-pushed
the
fix_qualify_unnest
branch
from
fea0204 to
41cfa9e
Compare
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
@fivetran-BradfordPaskewitz another quick round of comments from me, but this should be good to merge soon.
@tobymao wanna take a look as well? Another pair of eyes is a good idea for this one.
… processing UNNEST source
fivetran-BradfordPaskewitz
force-pushed
the
fix_qualify_unnest
branch
from
41cfa9e to
7428a39
Compare
georgesittas
approved these changes
Dec 11, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Great work @fivetran-BradfordPaskewitz, looks reasonable 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://fivetran.atlassian.net/browse/RD-1066808
Problem: In BigQuery, when you UNNEST an ARRAY<STRUCT<...>>, the struct fields can be referenced as unqualified columns (e.g., WHERE type = 'x'). This worked in simple queries but failed in correlated subqueries because sqlglot's type annotation couldn't resolve columns from outer scopes, so qualify_columns didn't know what struct fields to expose.
Solution: Add a fallback mechanism in qualify_columns.py that queries the schema directly when type annotation fails. When processing an UNNEST source, if the expression isn't typed, traverse parent scopes to find the column's type definition in the schema (handling both table sources and CTEs), then extract and expose the struct field names as available columns in that scope.