[chore] Use static token in GitHub source #3834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some minor formatting in sources.go
mcastorina
commented
Jan 8, 2025
Comment on lines
30
to
34
| tokenSource := oauth2.StaticTokenSource(&oauth2.Token{AccessToken: token}) | ||
| httpClient.Transport = &oauth2.Transport{ | ||
| Base: httpClient.Transport, | ||
| Source: oauth2.ReuseTokenSource(nil, tokenSource), | ||
| Source: tokenSource, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Maybe I misunderstood what ReuseTokenSource does, but since tokenSource is a StaticTokenSource, I didn't think we needed the ReuseTokenSource to wrap it.
rosecodym
approved these changes
Jan 9, 2025
Contributor
rosecodym
left a comment
rosecodym
left a comment
There was a problem hiding this comment.
Seems straightforward to me. Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Also some minor formatting in sources.go
Checklist:
make test-community)?make lintthis requires golangci-lint)?