Add a way to access the output_path in generated BUILD files #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
reviewed
Oct 30, 2024
| if not repository_ctx.path("BUILD").exists and not repository_ctx.path("BUILD.bazel").exists: | ||
| if build_file_content: | ||
| repository_ctx.file("BUILD", content = build_file_content) | ||
| repository_ctx.file("BUILD", content = build_file_content.replace("{{NIX_STORE_PATH}}", output_path)) |
Member
There was a problem hiding this comment.
Nice, that could potentially have simplified things like the Python toolchain.
I guess the same could be done with the build_file attribute using repository_ctx.template for consistency.
This behavior should also be documented in the relevant repo macros / module extension tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really useful to avoid Bazel seeing the files themselves considering they are already in the nix store. No point in copying them in the bazel cache