WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Aslam97
Copy link
Member

@Aslam97 Aslam97 commented Oct 29, 2025

Changes Overview

Fix findElementNextToCoords so that when it maps a top-level DOM block to a ProseMirror position and state.doc.nodeAt(pos) returns null (for example, when the position falls inside an atom node that allows inline content), it falls back to the containing parent node instead. This ensures the drag handle targets the correct block element in those cases.

Implementation Details

  • In findElementNextToCoords, handle the case where state.doc.nodeAt(pos) is null.
  • Resolve the position via state.doc.resolve(pos) and derive the parent node from the resolved position.
  • Return that parent as resultNode and use resolvedPos.start() as the position for the block.

Testing Done

Manually verified drag-handle behavior on Notion-like template

Verification Steps

  1. Create an atom node which allows inline content inside it.
  2. Try dragging that block using the drag handle.
  3. Confirm the behavior:
    • If the block contains regular content, dragging works as expected.
    • If the atom node is empty (no inline content), dragging failed to move the node — this fix ensures the correct parent block is targeted so dragging works in both cases.

Additional Notes

Screen.Recording.2025-12-05.at.01.mp4

Checklist

Related Issues

…th-inline

When pos maps into an atom node that allows inline content, state.doc.nodeAt(pos) may be null. Resolve the position and return the parent
Copilot AI review requested due to automatic review settings October 29, 2025 09:01
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: cbc0cbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 70 packages
Name Type
@tiptap/extension-drag-handle Patch
@tiptap/extension-drag-handle-react Patch
@tiptap/extension-drag-handle-vue-2 Patch
@tiptap/extension-drag-handle-vue-3 Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-caret Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-details Patch
@tiptap/extension-document Patch
@tiptap/extension-emoji Patch
@tiptap/extension-file-handler Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-font-family Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-invisible-characters Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list Patch
@tiptap/extension-mathematics Patch
@tiptap/extension-mention Patch
@tiptap/extension-node-range Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-of-contents Patch
@tiptap/extension-table Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-unique-id Patch
@tiptap/extension-youtube Patch
@tiptap/extensions Patch
@tiptap/html Patch
@tiptap/markdown Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/static-renderer Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch
@tiptap/extension-character-count Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-focus Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-history Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit cbc0cbd
🔍 Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/6931cc2734eefc0008b5caa0
😎 Deploy Preview https://deploy-preview-7139--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a null handling issue in the drag handle extension where nodeAt(pos) can return null for certain edge cases, specifically when dealing with atom nodes that allow inline content.

  • Added null check for node after state.doc.nodeAt(pos) call
  • Implemented fallback logic to resolve the parent node using state.doc.resolve(pos)
  • Added changeset documentation explaining the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/extension-drag-handle/src/helpers/findNextElementFromCursor.ts Added null check and fallback logic to handle cases where nodeAt(pos) returns null by resolving the parent node instead
.changeset/lazy-impalas-burn.md Added changeset documentation for the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2025

Open in StackBlitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@7139

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@7139

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@7139

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@7139

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@7139

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@7139

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@7139

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@7139

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@7139

@tiptap/extension-collaboration-caret

npm i https://pkg.pr.new/@tiptap/extension-collaboration-caret@7139

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@7139

@tiptap/extension-details

npm i https://pkg.pr.new/@tiptap/extension-details@7139

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@7139

@tiptap/extension-drag-handle

npm i https://pkg.pr.new/@tiptap/extension-drag-handle@7139

@tiptap/extension-drag-handle-react

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-react@7139

@tiptap/extension-drag-handle-vue-2

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-2@7139

@tiptap/extension-drag-handle-vue-3

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-3@7139

@tiptap/extension-file-handler

npm i https://pkg.pr.new/@tiptap/extension-file-handler@7139

@tiptap/extension-emoji

npm i https://pkg.pr.new/@tiptap/extension-emoji@7139

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@7139

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@7139

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@7139

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@7139

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@7139

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@7139

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@7139

@tiptap/extension-invisible-characters

npm i https://pkg.pr.new/@tiptap/extension-invisible-characters@7139

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@7139

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@7139

@tiptap/extension-mathematics

npm i https://pkg.pr.new/@tiptap/extension-mathematics@7139

@tiptap/extension-list

npm i https://pkg.pr.new/@tiptap/extension-list@7139

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@7139

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@7139

@tiptap/extension-node-range

npm i https://pkg.pr.new/@tiptap/extension-node-range@7139

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@7139

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@7139

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@7139

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@7139

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@7139

@tiptap/extension-table-of-contents

npm i https://pkg.pr.new/@tiptap/extension-table-of-contents@7139

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@7139

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@7139

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@7139

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@7139

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@7139

@tiptap/extension-unique-id

npm i https://pkg.pr.new/@tiptap/extension-unique-id@7139

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@7139

@tiptap/extensions

npm i https://pkg.pr.new/@tiptap/extensions@7139

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@7139

@tiptap/markdown

npm i https://pkg.pr.new/@tiptap/markdown@7139

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@7139

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@7139

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@7139

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@7139

@tiptap/static-renderer

npm i https://pkg.pr.new/@tiptap/static-renderer@7139

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@7139

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@7139

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@7139

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@7139

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@7139

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@7139

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@7139

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@7139

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@7139

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@7139

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@7139

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@7139

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@7139

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@7139

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@7139

commit: cbc0cbd

@Aslam97 Aslam97 requested review from arnaugomez and removed request for arnaugomez November 12, 2025 11:20
@arnaugomez
Copy link
Contributor

Review the "Checklist" section of the PR description

@Aslam97
Copy link
Member Author

Aslam97 commented Dec 4, 2025

Reviewed the checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants