-
Notifications
You must be signed in to change notification settings - Fork 3
「CSS による配置」を改訂 #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
「CSS による配置」を改訂 #891
Conversation
Deploying utcode-learn with
|
| Latest commit: |
56a3153
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f320183.utcode-learn.pages.dev |
| Branch Preview URL: | https://rewrite-css-arrangement.utcode-learn.pages.dev |
3f0bd0b to
86bec36
Compare
b40ab58 to
4b0f703
Compare
4b0f703 to
cceb0dd
Compare
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
途中ですが
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request revises the CSS layout documentation (「CSS による配置」を改訂) by simplifying and reorganizing the content. The PR introduces a new, more streamlined tutorial focused on building pricing plan cards while teaching CSS layout fundamentals.
Key Changes:
- Creates new simplified CSS layout guide with step-by-step card building examples
- Removes the advanced "CSS arrangement" content (box model, positioning, grid)
- Adds multiple progressive code samples demonstrating width, border, padding, margin, flexbox, and responsive design
Reviewed Changes
Copilot reviewed 50 out of 80 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/2-browser-apps/05-css-layout/index.mdx | New tutorial teaching CSS layout through building pricing cards, covering width/height, borders, padding, margin, flexbox, and media queries |
| docs/2-browser-apps/05-css-layout/_samples/* | Multiple sample code directories added to demonstrate each concept progressively |
| docs/2-browser-apps/05-css-layout/final-image.png | Screenshot showing the completed pricing card layout |
| docs/2-browser-apps/05-css-arrangement/index.mdx | Previous advanced CSS content removed (box model, position, grid) |
| docs/2-browser-apps/05-css-arrangement/_samples/* | All previous sample code removed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/2-browser-apps/05-css-layout/_samples/media-query/index.html
Outdated
Show resolved
Hide resolved
docs/2-browser-apps/05-css-layout/_samples/media-query/index.html
Outdated
Show resolved
Hide resolved
|
(メモ) 演習問題と、コードブロックのハイライトの CSS 以外を一旦修正 |
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他はわかりやすく正確で非常にいいと思います!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 50 out of 80 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
17f985c to
2554e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 62 out of 100 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/2-browser-apps/05-css-layout/_samples/responsive-header/index.html
Outdated
Show resolved
Hide resolved
7b743f7 to
d87255a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません。操作を誤り、途中でレビューを完了してしまいました。
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
説明がわかりやすくかなり正確で非常に良いと思います!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 62 out of 99 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もう問題ないと思います!
難易度も適切で、説明もわかりやすく、問題と演習問題の例も素敵だと思います。
ありがとうございます。
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
完璧だと思います!
「CSS による配置」で扱う内容を抜本的に見直し、例題のテーマも実用的なものに変更した
注意点