-
Notifications
You must be signed in to change notification settings - Fork 1.1k
cpu: aarch64: conv: optimize sve_1x1 kernel #4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6acb9d9 to
4603858
Compare
Could you provide a high-level description of what optimisations you made, and what bug you fixed? |
951b6f2 to
d32cfe5
Compare
a3b55f4 to
779dbc1
Compare
9445f69 to
9f5c0be
Compare
160fa74 to
fdec0e1
Compare
|
All nightly unit tests are passing and a lot of conv regressions are resolved with this patch: https://github.com/uxlfoundation/oneDNN/actions/runs/19906852997 |
jondea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great work, massive speed ups, thank you! I just have some minor comments.
It's probably not worth it at this point, but I'd say that in future, it would have been easier to understand if each optimization had its own commit which explained the reasoning.
7fcf24d to
9914fc0
Compare
- Apply 1x1 conv optimizations - Fix potential bug in brgemm_conv kernel Speedups on 16 threads: c7g: ~1.11 c8g: ~1.11x ~ 1.89x
9914fc0 to
21ab50f
Compare
Speedups on 16 threads:
c7g: ~1.11
c8g: ~1.11x ~ 1.89x