WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Ryo-not-rio
Copy link
Contributor

@Ryo-not-rio Ryo-not-rio commented Dec 2, 2025

  • Removed unnecessary loads
  • Updated to use LD_MUL_VL and ST_MUL_VL where possible
  • Move add_vl_or_imm to jit_generator.hpp and change add_imm to add_vl_or_imm where appropriate
  • Updated to NOT use explicit broadcast in most cases
  • Fix potential invalid immediate parameter for ld1rw in brgemm_kernel

Speedups on 16 threads:
c7g: ~1.11
c8g: ~1.11x ~ 1.89x

@Ryo-not-rio Ryo-not-rio requested a review from a team as a code owner December 2, 2025 10:53
@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Dec 2, 2025
@Sqvid
Copy link
Contributor

Sqvid commented Dec 2, 2025

  • Apply 1x1 conv optimizations
  • Fix potential bug in brgemm_conv kernel

Could you provide a high-level description of what optimisations you made, and what bug you fixed?

@Ryo-not-rio Ryo-not-rio force-pushed the ryo-not-rio/fix-brg branch 6 times, most recently from 951b6f2 to d32cfe5 Compare December 2, 2025 17:42
@Ryo-not-rio Ryo-not-rio requested review from a team as code owners December 3, 2025 11:05
@github-actions github-actions bot added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 3, 2025
@github-actions github-actions bot removed the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 3, 2025
@Ryo-not-rio Ryo-not-rio force-pushed the ryo-not-rio/fix-brg branch 3 times, most recently from 9445f69 to 9f5c0be Compare December 3, 2025 16:29
@github-actions github-actions bot added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 3, 2025
@github-actions github-actions bot removed the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 3, 2025
@Ryo-not-rio
Copy link
Contributor Author

All nightly unit tests are passing and a lot of conv regressions are resolved with this patch: https://github.com/uxlfoundation/oneDNN/actions/runs/19906852997

Copy link
Contributor

@jondea jondea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work, massive speed ups, thank you! I just have some minor comments.

It's probably not worth it at this point, but I'd say that in future, it would have been easier to understand if each optimization had its own commit which explained the reasoning.

@Ryo-not-rio Ryo-not-rio force-pushed the ryo-not-rio/fix-brg branch 2 times, most recently from 7fcf24d to 9914fc0 Compare December 4, 2025 13:59
@Ryo-not-rio Ryo-not-rio requested a review from jondea December 5, 2025 15:04
- Apply 1x1 conv optimizations
- Fix potential bug in brgemm_conv kernel

Speedups on 16 threads:
c7g: ~1.11
c8g: ~1.11x ~ 1.89x
@Ryo-not-rio Ryo-not-rio removed request for a team December 9, 2025 17:01
@Ryo-not-rio Ryo-not-rio merged commit c4c989d into main Dec 9, 2025
24 checks passed
@Ryo-not-rio Ryo-not-rio deleted the ryo-not-rio/fix-brg branch December 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants