fixup: asynchronous runtime support: fix the C++20 build #4439
+238
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
dzarukin
force-pushed
the
dzarukin/fixup_async
branch
from
ceb9e3b to
1cef7a9
Compare
densamoilov
approved these changes
Dec 9, 2025
avmanerikar
approved these changes
Dec 9, 2025
dzarukin
force-pushed
the
dzarukin/fixup_async
branch
from
1cef7a9 to
f75b81b
Compare
github-actions
bot
added
platform:gpu-nvidia
vpirogov
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MFDNN-14455
MFDNN-14417 - code adjustment for this one.
Referencing to
thismust be done in an explicit way in C++20 which is in contradiction with C++17.Decided to just patch places up if new come up as building macros infrastructure to support both standards seems to be a slight overkill.
Note: thanks to clang-format update, this PR takes not 6K (3K+, 3K-) lines of moved lambdas but just 300.