Log exceptions in autotune_policy - tests
#2472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds exception handling and logging to test files for autotune policy and related dynamic selection policies. The changes wrap existing test code in try-catch blocks to capture and log any exceptions that occur during test execution.
- Adds try-catch blocks around main test logic in multiple test files
- Implements consistent exception logging using TestUtils::issue_error_message
- Ensures tests can report meaningful error information when exceptions occur
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_round_robin_policy_inline.pass.cpp | Adds basic try-catch wrapper around test execution |
| test_fixed_resource_policy_inline.pass.cpp | Adds basic try-catch wrapper around test execution |
| test_dynamic_load_policy_inline.pass.cpp | Adds try-catch with exception logging functionality |
| test_customizations.pass.cpp | Adds try-catch with exception logging functionality |
| test_auto_tune_policy_inline.pass.cpp | Adds try-catch with exception logging functionality |
| test_auto_tune_policy_sycl.pass.cpp | Adds try-catch with exception logging functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test/parallel_api/dynamic_selection/test_round_robin_policy_inline.pass.cpp
Show resolved
Hide resolved
test/parallel_api/dynamic_selection/test_fixed_resource_policy_inline.pass.cpp
Show resolved
Hide resolved
SergeyKopienko
requested review from
danhoeflinger,
dmitriy-sobolev and
vossmjp
….cpp - log exceptions
…ass.cpp - log exceptions
…ass.cpp - log exceptions
….pass.cpp - log exceptions
…ss.cpp - log exceptions
…ss.cpp - log exceptions
…l.pass.cpp - log exceptions
…ycl.pass.cpp - log exceptions
….pass.cpp - log exceptions
SergeyKopienko
force-pushed
the
dev/skopienko/log_auto_tune_policy_test_exceptions
branch
from
829c070 to
a401210
Compare
danhoeflinger
approved these changes
Sep 23, 2025
Contributor
danhoeflinger
left a comment
danhoeflinger
left a comment
There was a problem hiding this comment.
Sure, this LGTM.
Thanks Sergey
SergeyKopienko
deleted the
dev/skopienko/log_auto_tune_policy_test_exceptions
branch
danhoeflinger
pushed a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exception handling and logging to test files for autotune policy and related dynamic selection policies. The changes wrap existing test code in try-catch blocks to capture and log any exceptions that occur during test execution.