feat(provider/vertex): add express mode #10931
Open
+167
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the Vertex example with express mode and gets rid of GOOGLE_API_KEY which wasn't used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This adds express mode support to Vertex which is a simplified version of authentication compared to the default OAuth flow.
Summary
Express mode uses a different base URL and requires the api key to be added as a search parameter. Since we need to bypass the default OAuth flow I also added checks to the
Manual Verification
Haven't been able to do this yet due to my Google account being old and messed up. Still posting this PR in the meantime.
Checklist
pnpm changesetin the project root)Future Work
Related Issues
Fixes #10058