WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@MrZ20
Copy link
Contributor

@MrZ20 MrZ20 commented Dec 8, 2025

What this PR does / why we need it?

This PR refactors the E2E multicard test suite to improve test case identification and maintainability. Specifically, it renames various test functions to be more descriptive (explicitly indicating model families like Qwen/DeepSeek and parallelism strategies like DP/TP/PP/EP) and cleans up outdated or redundant test configurations in the offline distributed inference tests.

Key Changes:

  1. Test Function Renaming (Standardization): Renamed multiple test functions across tests/e2e/multicard/ to include clear suffixes/prefixes regarding the model and parallel strategy. This helps differentiate test cases in CI logs and prevents naming collisions.

test_aclgraph_capture_replay.py:

  • test_aclgraph_capture_replay_dp2 -> test_aclgraph_capture_replay_metrics_dp2

test_data_parallel.py:

  • test_data_parallel_inference -> test_qwen_inference_dp2

test_data_parallel_tp2.py:

  • test_data_parallel_inference -> test_qwen_inference_dp2_tp2

test_expert_parallel.py:

  • test_e2e_ep_correctness -> test_deepseek_correctness_ep

test_external_launcher.py:

  • test_external_launcher -> test_qwen_external_launcher
  • test_moe_external_launcher -> test_qwen_moe_external_launcher_ep
  • test_external_launcher_and_sleepmode -> test_qwen_external_launcher_with_sleepmode
  • test_external_launcher_and_sleepmode_level2 -> test_qwen_external_launcher_with_sleepmode_level2
  • test_mm_allreduce -> test_qwen_external_launcher_with_matmul_allreduce

test_full_graph_mode.py:

  • test_models_distributed_Qwen3_MOE_TP2_WITH_FULL_DECODE_ONLY -> test_qwen_moe_with_full_decode_only
  • test_models_distributed_Qwen3_MOE_TP2_WITH_FULL -> test_qwen_moe_with_full

test_fused_moe_allgather_ep.py:

  • test_generate_with_allgather -> test_deepseek_moe_fused_allgather_ep
  • test_generate_with_alltoall -> test_deepseek_moe_fused_alltoall_ep

test_offline_weight_load.py:

  • test_offline_weight_load_and_sleepmode -> test_qwen_offline_weight_load_and_sleepmode

test_pipeline_parallel.py:

  • test_models -> test_models_pp2
  1. Distributed Inference Cleanup (test_offline_inference_distributed.py):

model list changes:

QWEN_DENSE_MODELS = [
-     "vllm-ascend/Qwen3-8B-W8A8", "vllm-ascend/Qwen2.5-0.5B-Instruct-W8A8"
+     "vllm-ascend/Qwen3-0.6B-Instruct-W8A8",
]
- QWEN_W4A8_OLD_VERSION_MODELS = [
-    "vllm-ascend/Qwen3-8B-W4A8",
- ]

- QWEN_W4A8_NEW_VERSION_MODELS = [
-     "vllm-ascend/DeepSeek-V3-W4A8-Pruing",
-     "vllm-ascend/DeepSeek-V3.1-W4A8-puring",
- ]

+ DEEPSEEK_W4A8_MODELS = [
+      "vllm-ascend/DeepSeek-V3.1-W4A8-puring",
+ ]

Test Function Changes:

  • removed test_models_distributed_QwQ
  • removed test_models_distributed_Qwen3_W8A8
  • removed test_models_distributed_Qwen3_W4A8DYNAMIC_old_version
  • test_models_distributed_Qwen3_W4A8DYNAMIC_new_version -> test_models_distributed_Qwen3_W4A8DYNAMIC

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up the end-to-end tests. The changes primarily involve renaming test files and functions to be more descriptive and accurate, which improves the maintainability and clarity of the test suite. Additionally, several obsolete models and tests have been removed, and model lists for testing have been updated. The changes are well-aligned with the goal of cleaning up the test code. I have reviewed the pull request and found no critical or high-severity issues.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Dec 9, 2025
Signed-off-by: MrZ20 <[email protected]>
Signed-off-by: MrZ20 <[email protected]>
Signed-off-by: MrZ20 <[email protected]>
Signed-off-by: MrZ20 <[email protected]>
Signed-off-by: MrZ20 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants