WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@zlice
Copy link
Contributor

@zlice zlice commented Oct 21, 2025

Testing the changes

  • I tested the changes in this PR: briefly

mesa and wlroots worked

Local build testing

  • I built this PR locally for my native architecture, x86_64, cross i686 (mesa)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
  • x86_64-musl

Comments

didn't do the same as meson 1.8.2 #56014 with cflags/sanitizer in post-patch. obviously replaces that PR

budgie-desktop: updated to 10.9.3 and added some dev deps, wasn't building in 1.8.2 previously removed changes, but for reference budgie-desktop-template.txt

@zlice
Copy link
Contributor Author

zlice commented Oct 21, 2025

well idk musl well enough, does it even support asan? sure somebody here knows

@zlice
Copy link
Contributor Author

zlice commented Oct 22, 2025

budgie-desktop fails on cross. tried gettext-0.26 and installing appstream for the cross builds but no dice. will probably remove the budgie bit.

@zlice
Copy link
Contributor Author

zlice commented Oct 22, 2025

for musl asan just patched the unittests/linuxliketests.py file directly, and added a is_musl() to mesonbuild/utils/universal.py.

i think last time i did a post_patch() a real patch was recommended anyway.

see https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/meson/skip-broken-tests.patch

more specifically mesonbuild/meson#8283

left out the bungie-desktop stuff

@dogknowsnx
Copy link
Contributor

dogknowsnx commented Oct 25, 2025

Built w/o issues:

  • dav1d
  • gtk-layer-shell
  • labwc
  • mangowc
  • zathura

(Will test building more packages later - x86_64-glibc)

@onlylunix
Copy link
Contributor

onlylunix commented Oct 27, 2025

libdrm compiled successfully.
By the way, the libdrm checksum doesn't match.
This needs to be fixed, or better yet, updated.
Create PR #57692

@onlylunix
Copy link
Contributor

onlylunix commented Oct 27, 2025

mesa-25.2.5 compiled successfully.
To build libdrm and mesa, I needed to add python3-packaging to the hostmakedepends variable.
python3-packaging probably needs to be added to the meson package depends variable.

Sorry for the translator, my native language is Russian.

@classabbyamp classabbyamp merged commit c9e5c79 into void-linux:master Nov 9, 2025
8 checks passed
@ahesford
Copy link
Member

ahesford commented Nov 9, 2025

@zlice your patch breaks meson because it adds a dependency on python3-packaging that is not reflected in the package metadata. In general, patches that do not reflect upstream fixes should never add functions to the public interface of a package. The right thing to do is replicate the actual Alpine patch and selectively apply it only for musl.

Comment on lines +26 to +28
+def is_musl() -> bool:
+ tags = list(sys_tags() )
+ return "musl" in tags[0].platform

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this upstream it needs to do something like check for __MUSL__.

Don't use third-party libraries (meson has none by design and this adds a runtime dep solely to get a testsuite hack to work) which depend on import sys; analyze_elffile(sys.executable) to check if DT_INTERP contains the word "musl" and fails when python is statically linked or CC=musl-gcc + a glibc system.

@zlice zlice deleted the meson191 branch December 30, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants