-
Notifications
You must be signed in to change notification settings - Fork 2.5k
meson: update to 1.9.1 #57635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: update to 1.9.1 #57635
Conversation
|
well idk musl well enough, does it even support asan? sure somebody here knows |
|
budgie-desktop fails on cross. tried gettext-0.26 and installing appstream for the cross builds but no dice. will probably remove the budgie bit. |
|
for musl asan just patched the i think last time i did a post_patch() a real patch was recommended anyway. see https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/meson/skip-broken-tests.patch more specifically mesonbuild/meson#8283 left out the bungie-desktop stuff |
|
Built w/o issues:
(Will test building more packages later - x86_64-glibc) |
|
|
|
Sorry for the translator, my native language is Russian. |
|
@zlice your patch breaks meson because it adds a dependency on |
| +def is_musl() -> bool: | ||
| + tags = list(sys_tags() ) | ||
| + return "musl" in tags[0].platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this upstream it needs to do something like check for __MUSL__.
Don't use third-party libraries (meson has none by design and this adds a runtime dep solely to get a testsuite hack to work) which depend on import sys; analyze_elffile(sys.executable) to check if DT_INTERP contains the word "musl" and fails when python is statically linked or CC=musl-gcc + a glibc system.
Testing the changes
mesa and wlroots worked
Local build testing
Comments
didn't do the same as meson 1.8.2 #56014 with cflags/sanitizer in post-patch. obviously replaces that PRbudgie-desktop: updated to 10.9.3 and added some dev deps, wasn't building in 1.8.2 previouslyremoved changes, but for reference budgie-desktop-template.txt